Nick Mancuso

Results 389 comments of Nick Mancuso

> @nmancus1 , please make summary of where we are now. We need to generate reports from checkstyle directly, but this issue is last on the list of improvements to...

> @nrmancuso ping. What blocks this? I think this will make diff report execution take too long/too much memory. I need to reevaluate this. We should probably just replace 17...

> Only one jdk code is required for execution. Keep latest with exclusion on files that we can not parse yet. Agreed, they do a good job of keeping old...

> @rnveach @nrmancuso @romani > > I think this got missed please replace jdk17 with 21. As you said old inputs aren't removed so we won't miss it we just...

Closed in favor of https://github.com/checkstyle/contribution/pull/878

>Minor addition, Sevntu also uses launch.groovy . See https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/.ci/wercker.sh#L35 . I am making updates to existing issues as I see/remember things we need to be mindful of in this revamp....

@rnveach if you agree with comments at https://github.com/checkstyle/contribution/issues/523#issuecomment-759570711, then I can proceed with https://github.com/checkstyle/contribution/issues/529 this week. I will plan on adding groovy tests in #529 in this case.

Update: I am currently working on #529. Some thoughts to leave here: Regarding https://github.com/checkstyle/contribution/issues/273: I plan to use @rnveach's scripts located at https://github.com/rnveach/contribution/tree/rvmaster/checkstyle-tester as a starting point, namely the logic...

In a perfect world, all the CI we use would allow us to use custom images. Then, we could just keep our `checkstyle/jdk-11-groovy-git-mvn:11.0.13__3.0.9__2.25.1__3.6.3` image up to date and use it...

@romani @rnveach please setup CircleCI for this repo using this link (if you want to go this route): https://app.circleci.com/settings/project/github/checkstyle/contribution?utm_campaign=locked_project&utm_content=project_dashboard_tooltip&utm_medium=copy_admin_project_set_up_link&utm_source=circleci_onboarding