Nick Mancuso
Nick Mancuso
>I see no problem ... > I pretty sure ... >I agree to ... This issue description sounds highly subjective and personal; we should take the check's description at face...
> Default set of identifiers can be jdk11 based, so it will not be my personal preferences, just old in style. Why? We agreed last summer to keep checks updated...
@romani If you want to ignore my feedback (and the checks description) and change the check to use your personal preferences, that is one thing. However, please do not approve...
I do not approve of this update, but it doesn’t matter. I will place the approved label on this issue since the description now at least clearly describes the work...
When we close this , we can remove the following comments: ```bash ➜ checkstyle git:(issue-3145-b) grep -R "#8205" src/it/resources/com/google/checkstyle/test/chapter4formatting/rule462horizontalwhitespace/InputNoWhitespaceBeforeAnnotations.java: @NonNull int @NonNull[] @NonNull[] fiel1; // ok until #8205 src/it/resources/com/google/checkstyle/test/chapter4formatting/rule462horizontalwhitespace/InputNoWhitespaceBeforeAnnotations.java: public...
From the description, it seems to me that this exact behavior can be achieved by the `haltOnException` property and a `SuppressionSingleFilter` module: ``` ➜ src cat config.xml ➜ src cat...
Ok, we have a nuance with workaround at https://github.com/checkstyle/checkstyle/issues/12542#issuecomment-1362261537: https://github.com/checkstyle/checkstyle/issues/12507#issuecomment-1366683265 >there is a nuance, modules are executed sequentially: ``` ➜ src cat config.xml ➜ src java -jar checkstyle-10.4-all.jar -c config.xml...
Ok, let me try to sum up our discussion: 1. We will introduce a new property called `skipFileOnJavaParseException`: ``` ``` 2. We will introduce a new property called `skipFileOnJavadocParseException`: ```...
This is a big win for users, thanks to @mahfouz72 for getting this across the finish line! 🚀
@Vyom-Yadav it might be a good idea to discuss high level implementation of expression evaluation idea in here first before sending PR.