Nick Mancuso
Nick Mancuso
> @nrmancuso, in general i struggle with jacoco coverage. And, especially with this, i am struggling to create a jacoco coverage for the while loop i.e. `while (parent !=null)`. Can...
@relentless-pursuit thanks a lot for the explanation; I had completely forgotten about the overhaul to this check. I hope that it makes your life easier in this PR :) Let's...
@relentless-pursuit how's it going here? Can we help with something?
> @nrmancuso sorry for the ping. Any feedback on the development so far on this PR? No need to be sorry :) Feedback from me is that first we need...
> @nrmancuso ping Need a bit of time to get to this one, thanks for the reminder
@relentless-pursuit please make CI happy, then I will hand off to the next reviewer. Thanks for this!
Let’s try to apply patch one more time, it looks like ordering changed
> > Let’s try to apply patch one more time, it looks like ordering changed > > I tried that by placing suppressions of `FallThroughCheck.java` together. But, the failure persists....
Let's just remove parent pom if this doesn't cause any issues.
@romani I am good to approve based on findings at https://github.com/checkstyle/checkstyle/pull/14397, please add label if you agree