Nick Mancuso

Results 407 comments of Nick Mancuso

@0xbakry it looks like at least CircleCI is not running on this PR, they have some sanctions against IPs in certain countries

@romani @aayushRedHat where are we at with this PR? I don't see any specific questions in the issue that need to be answered.

This feels like it should be its own check, `OverloadedConstructorOrder`, since there are a few nuances with constructors such as compact constructors in records. Each check should only care about...

Why we should create a new check: 1. Constructors are not methods, they should not be checked by `OverloadMethodsDeclarationOrder` 2. Logic of checking constructors is different, since they do not...

> @nrmancuso thanks for the detailed explanation, you have strong points... @rnveach can you pls confirm on how we should approach this issue? then I will start working on this...

@Zopsss if you are in agreement about creating a new check, please update the issue description and title to match.

@Zopsss we need to extend issue description to show good and bad code, with classes and records to show users clearly what the behavior should be and make sure we...

I would expect the general behavior of this check to follow whatever `MethodDeclarationOrder` does for grouping/ordering. The documentation at https://checkstyle.org/checks/coding/overloadmethodsdeclarationorder.html#Example1-code gave me the impression that we ordered methods by number...