Nick Mancuso

Results 378 comments of Nick Mancuso

Hopefully it is testing ground :)

Test methods should not have to care about which verify method to use. Either try and fail to parse one type and the try other, or use special comment format...

Since we only deprecate this class in scope of this issue, and do full removal in https://github.com/checkstyle/checkstyle/issues/12873, this makes sense.

bug might be misleading, but it corresponds to minor version bump which is good for deprecation. This will get attention from users and signal that we will be making breaking...

Honestly, I am pretty confused about what's going on here. We are referencing closed/blocked/discussion ongoing issue. Why do we need the change in command line args? Can this be merged...

@Rohanraj123 comment at https://github.com/checkstyle/checkstyle/pull/14480#issuecomment-1951335993 is very difficult to understand, please always use code blocks for code/CLI output. It is not clear to me what the question here is. Please read...

>isnt working in my terminal Please google the output, also share here and maybe we can recognize something.

@romani this PR has been hanging for three years, we need to proceed with review or close it.

> You are close to green CI. @romani we are missing almost half of our CI workflows in this PR.