Nick Mancuso

Results 388 comments of Nick Mancuso

>I have multiple successful open PRs which are ready to merge but I won't be bugging any of you about those. Isn't this "bugging"? 😂 We still need approval from...

Really, your proposed message is much less helpful than the original. If we don’t share the expected pattern with the user, they will have to dig into their configuration file...

The only reasonable improvement I can think of is to go from: `[ERROR] C:\Users\chri0\Documents\checkstylePRJ\.\Test.java:2:11: Name 'var' must match pattern '(?i)^(?!(record|yield|var|permits|sealed|_)$).+$'. [IllegalIdentifierName]` To Something like: `[ERROR] C:\Users\chri0\Documents\checkstylePRJ\.\Test.java:2:11: Identifier 'var' matches illegal...

Agree 100%, I think overuse of comments diminishes the concision of examples and inputs.

@sheetalj2205 we do not assign issues except to maintainers, just make a comment like “I am on XXXCheck” and send a PR.

I am on MethodParamPadCheck

We have an exception in SingleSpaceSeparatorCheck: ``` Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 1441 out of bounds for length 22 at com.puppycrawl.tools.checkstyle.checks.whitespace.SingleSpaceSeparatorCheck.isSpace (SingleSpaceSeparatorCheck.java:211) at com.puppycrawl.tools.checkstyle.checks.whitespace.SingleSpaceSeparatorCheck.isSingleSpace (SingleSpaceSeparatorCheck.java:200) at com.puppycrawl.tools.checkstyle.checks.whitespace.SingleSpaceSeparatorCheck.isTextSeparatedCorrectlyFromPrevious (SingleSpaceSeparatorCheck.java:184) at com.puppycrawl.tools.checkstyle.checks.whitespace.SingleSpaceSeparatorCheck.visitEachToken (SingleSpaceSeparatorCheck.java:147)...

Latest report generation: https://github.com/nrmancuso/checkstyle-diff-report-generator/actions/runs/8143434490

@akankshat05 how can we help to get this PR out of draft mode?