Nicko Guyer

Results 65 comments of Nicko Guyer
trafficstars

Thanks for opening this! This seems like an interesting idea and I or one of other maintainers will review this and provide some feedback as soon as we can, though...

Ah, it looks like the linter is complaining because a file was updated by the copyright year in the header wasn't also updated. Sorry, it's a silly linter rule. ```...

Closing and re-opening to get the build to run again

@niklas-emmelius-mittelstand-ai Sorry it took so long to get feedback on this one. If you want to rename `SubscriptionOptions` to `ListenerOptions` I'm happy to merge this PR. Thanks!

### Steps that I am following for validating migration scenarios: #### Multiparty Tests - [ ] Deploy a v1.2.2 stack - [ ] Enable multiparty mode (run the `./hack/multiparty.sh` script)...

This is great! Thank you so much for all the work on this, @EnriqueL8

Adding the `.golangci.yml` is the first step. Then `make` will start failing because the code doesn't meet the requirements of the linter rules in various places. So the second part...

Thanks! Sorry I missed the PR being opened for it. I'll take a look now!

Thanks for opening this! I think I have seen this issue as well. I thought I fixed it, but maybe it was a similar but slightly different issue. For background...

@peterbroadhurst Are you sure you are running the latest code in main? I think this existing check should allow this condition to not return the error: https://github.com/hyperledger/firefly-cli/blob/3679daf0650b0fa1870b86945603f2b2f71577d6/internal/stacks/stack_manager.go#L707-L709