firefly-fabconnect icon indicating copy to clipboard operation
firefly-fabconnect copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger

Add linter rules

Open nguyer opened this issue 2 years ago • 6 comments
trafficstars

Currently, this repo is set up to run golangci, but has no config file, so it's missing all of the rules that we apply to our other repos. We should add the .golangci.yml file from here: https://github.com/hyperledger/firefly/blob/main/.golangci.yml

Then we need to go through the code and address the issues that are uncovered.

nguyer avatar Feb 17 '23 21:02 nguyer

Hi @nguyer, I would like to pick up this issue. Is just adding the .golangci.yml sufficient enough?

PanGan21 avatar Mar 08 '23 20:03 PanGan21

Adding the .golangci.yml is the first step. Then make will start failing because the code doesn't meet the requirements of the linter rules in various places. So the second part of this issue is fixing those issues so that make succeeds again.

nguyer avatar Mar 08 '23 20:03 nguyer

Hi @nguyer I think both subtasks are done. I would appreciate a first review for #108 :)

PanGan21 avatar Mar 15 '23 18:03 PanGan21

Thanks! Sorry I missed the PR being opened for it. I'll take a look now!

nguyer avatar Mar 15 '23 18:03 nguyer

I had quite some progress on this issue. Most of the errors are fixed. Some of them which include additional configuration are ignored for now. (e.g. adding timeouts on the server). Let me know what you think

PanGan21 avatar Mar 20 '23 18:03 PanGan21

@nguyer is this issue still open? or how is progress on it @PanGan21 ?

tobyweb3x avatar Sep 14 '23 08:09 tobyweb3x