Nicko Guyer

Results 65 comments of Nicko Guyer
trafficstars

The FireFly CLI uses Fabric 2.3 or newer. That may cause an issue here. Could you update your Fabric version and try again?

Hey @Philip-21. Sorry I probably should have steered you in the direction of the existing code in the `firefly-signer` library that we already have that does these sorts of things....

@Philip-21 Looks like there are compilation errors now: ``` Error: ../internal/tokens/erc1155/erc1155_provider.go:93:41: cannot convert loc["address"] (map index expression of type string) to type types.HexAddress # github.com/hyperledger/firefly-cli/internal/tokens/erc20erc721 Error: ../internal/tokens/erc20erc721/erc20_erc721_provider.go:92:40: cannot convert loc["address"]...

`783688521890864681654499112172336319967459785509` looks like something that was an address which may have been converted to a number. Based on what I see in the E2E test log: ``` initializing token providers...

@gabriel-indik and or @peterbroadhurst might be good to ask about whether a namespace should start if a peer cannot be added. I'm actually not very familiar with the inner workings...

Thanks for continuing to move this forward @awrichar! On the **Fail Forward** case, does just skipping the custom blockchain call solve every case where we could get stuck with this?...

@peterbroadhurst I'm trying to pick this back up but really not sure what direction to take it. I think part of my struggle is that I myself haven't run into...

I'm seeing a slightly different behavior with a `require()` in my smart contract. Here is the test contract that I am using: ```solidity // SPDX-License-Identifier: Apache-2.0 pragma solidity ^0.8.10; //...

Upon more investigation this is due to the fact that the format of the token pool locator changed between v1.2.2 and now. I discussed this with @awrichar and we decided...

@Philip-21 > Would like to work on this @nguyer I have fixed this in https://github.com/hyperledger/firefly/pull/1388 and https://github.com/hyperledger/firefly-tokens-erc1155/pull/135