Nicko Guyer

Results 65 comments of Nicko Guyer
trafficstars

Thanks @matthew1001 for raising this. Trying to understand what is needed for this one. It looks like https://github.com/hyperledger/firefly-evmconnect/pull/130 only includes new unit tests. Are there additional code changes in EVMConnect...

It does let me pass value as a string though, as long as it is base 10, so I can still express large numbers which is good.

I hit this again today on a release build: https://github.com/hyperledger/firefly-ethconnect/runs/4288464013?check_suite_focus=true [build_log.txt](https://github.com/hyperledger/firefly-ethconnect/files/7582401/build_log.txt)

No, OrgName is separate from ID: https://github.com/hyperledger/firefly-cli/blob/main/pkg/types/organization.go#L20 Though in reality, now that the org name can be customized, I'm not sure how much value this feature has anymore

Hi @icemagno, thanks for the suggestions. If you're at the point of needing fine grained control of your configuration and needing to integrate FireFly with existing external systems, it sounds...

No problem 🙂 The local docker set up is a bit complex because part of the config needs to be written, processes started up, the a contract gets deployed, and...

The E2E tests are failing with this error: ``` ff -v --ansi never init ethereum --prometheus-enabled --database sqlite3 firefly_e2e 2 --token-providers erc1155 --manifest ../../manifest.json --sandbox-enabled=false --multiparty=true initializing new FireFly stack......

I think we still need this. I'd like to have assurance that changes in a PR won't prevent `make` from running locally before things get merged.

This is a good suggestion. The reason it works the way it does is that any error returned from a Cobra `RunE()` will print usage by default. So we'll need...

I think this is correct. In this case "bytes" are passed in as a string encded as hex or base64.