Nabil Freij

Results 767 comments of Nabil Freij

We should probably documentation the string formats and the types we support but I'm not sure where or how.

Well with your magic string magic that is magic. Can't we just use that everywhere?

We can create a magic decorator that does time magic

I am not sure we have this written down in our docs guidelines.

I have a broader comment. Can we not touch the original code but create a new coalignment folder and have separate files for the interface and each method? This would...

On the surface, I would rather return the shifted maps. It might be useful information to have tho but maybe I would want that to be a seperate function.

> I think optionally outputting the calculated shifts would be very useful, since it is already being calculated in this process. Would you want the map/cube and the shifts or...

> I am a bit confused by what sort of "coalignment" this is doing. Ideally when we have the interface in place, we can either re-write this method to be...

> Thanks, Nabil. I realize the actual alignment code is just one implementation. But I think my questions were mostly non-implementation-specific, about what inputs and outputs the users would like...