Nabil Freij

Results 802 comments of Nabil Freij

> 1. Concerning the signature, I've done it as `*args, **kwargs` so that changes in the signature in the [watroo ](https://github.com/frederic-auchere/wavelets) package would not have to be replicated systematically. Now...

> > 2. We inspect the WOW function and raise a warning/error if the input args/keywords do not match the signature. > > Can you point me to an example...

> > I don't think it would be trivial to solve like this, which is why I think that copying the args is easier/quicker but might not be the best...

Thank you and sorry for my late response. Would it be ok, if I debug the doc problems and push a fix?

I ended up finding a bunch of problems that were unrelated to your changes that I couldn't resist not fixing. So this PR kind of ballooned out of control.

Thank you for putting up with us @frederic-auchere

The doc build is failing: ``` :33: WARNING: py:obj reference target not found: sunkit_image.stara.stara :33: WARNING: Failed to create a cross reference. A title or caption not found: 'sphx_glr_download_generated_gallery_finding_sunspots_using_stara.py' ```...

Looks like we need to bump the figure test env. I can do that in a separate PR

Can you see if that works with stara?