Michael Gregorius

Results 324 comments of Michael Gregorius

Ah, so it is intended as some way of synchronization. Unfortunately, I don't have an overview of who's working on what. But to my knowledge it is rather seldom a...

I wouldn't even know where to put it. Please create a PR for it with an explanation of why you think this fixes the bug. This is usually the much...

> AFAICT, this PR tries to remove coupling to allow for a more flexible design so we can export specific things inside the project, like a sample. @szeli1, @sakertooth: If...

> > Perhaps all the stuff related to audioEncoderFactory in ProjectRenderer could be extracted into a service class which then lets you provide a file name and an export format....

> > > Interestingly, I have written just such a class to write raw audio files to debug another problem in LMMS. > > > > > > The problem...

> In that case, I would like having a proper audio graph first before we implement something like this. The solutions that don't use an audio graph could work, but...

> Also, tbh i don't understand what the feature is. It synchronizes LMMS' transport with the JACK transport and vice versa. There's a demonstration video by @firewall1110 in this comment:...

@DanielKauss, I only did a very quick review but overall I like that this PR lays the base to free the instruments from their confined and tiny windows. :smiley: Another...

I have just tested the PR locally and noticed that resizing is very slow and sluggish after having loaded a sample that's 15 seconds long. I guess it will be...

> Is the lag on resizing really that noticeable? I didn't change any of the drawing code from the original SlicerT, and there everything ran smoothly. If the lag is...