Michael Gregorius

Results 338 comments of Michael Gregorius

> Looks like this is related to #7114 and #7209, @michaelgregorius you have any idea? In how far do you think it is related? As in "is caused by it"?...

I have merged this pull request now as it solves the problem. Any potential further improvements can be done in separate pull requests.

I can reproduce the problem: [LMMS-ResizingAutomationClip.webm](https://github.com/user-attachments/assets/98d00477-01ae-4305-aba5-74419e3c7d17) The main problem seems to be that calling `AutomationClip::removeNode` does more than it should. It does not simply update the data structure, it also...

I have implemented the separation of concerns described in my last comment with pull request https://github.com/LMMS/lmms/pull/7472 which should fix this issue. Feel free to review it.

Linking this comment here as well for completeness: https://github.com/LMMS/lmms/pull/5990#issuecomment-2676379823

@JohannesLorenz, sorry, I have invited you because you were proposed by the GitHub UI which stated that you would have already done some development/reviews for the changed code area. Unfortunately,...

> Shrinking the automation clip to be less than one bar and then adding a node within the bounds of the clip does not resize it to one bar, which...

@bratpeki, work on an oscilloscope was started by @IanCaio some time ago. His branch is rather old but some months ago I merged it with `master´, fixed the build and...

I have just merged my current branch with `master` again and fixed the build once more (`sampleFrame` vs. `SampeFrame`). The current implementation looks like this: ![WaveAnalyzer](https://github.com/user-attachments/assets/d6ddf4dd-6698-41d1-b00e-6cedfabf2bf4) It looks like I...

Also linking https://github.com/LMMS/lmms/issues/1358 here which is an old request for an oscilloscope and vector scope. The vector scope was implemented in https://github.com/LMMS/lmms/pull/5328 so this issue would deal with the oscilloscope...