Michael Gregorius
Michael Gregorius
> Works great! Happy to hear that. :smiley: I will merge then. Thanks for testing this again!
> This PR seems to have caused an issue for me in which LMMS consistently segfaults upon opening settings. I am on Debian testing. > > stack trace: > >...
Ok, so I have installed Debian in a virtual machine and have fixed the bug with pull request https://github.com/LMMS/lmms/pull/8026.
> This PR seems to have caused an issue for me in which LMMS consistently segfaults upon opening settings. I am on Debian testing. @AW1534, this is now fixed in...
> And it appears the PR title and description are inaccurate, and the screenshot out-of-date? Because there are input selection combo boxes too. Yes, the screenshot is out of date...
> > Do other people keep their original PR descriptions up-to-date with regards to all latter changes? > > Yes, otherwise it's misleading to people trying to understand what the...
Here's how it looks with an alternative implementation using `QToolButton` which allows to select the input/output from a nested menu. https://github.com/user-attachments/assets/8bedf189-4d70-4946-bdac-13175c220478 The buttons look different to the other elements due...
The problem is caused by the plugin widgets simply setting the background image as the background brush without setting a fixed size according to the used background image for themselves....
The repeating background can indeed be fixed by setting a fixed size. I have tested this with ZynAddSubFx by replacing https://github.com/LMMS/lmms/blob/e50f31281862ab0d58a6b398d46a757c6727a056/plugins/ZynAddSubFx/ZynAddSubFx.cpp#L501 with ``` auto pixmap(PLUGIN_NAME::getIconPixmap("artwork")); pal.setBrush( backgroundRole(), pixmap); setFixedSize(pixmap.size()); ```...
Edit: I have noticed that this PR links https://github.com/LMMS/lmms/pull/7805 which has already identified and somewhat fixed the problem described below. The cause of some plugins being wider is the message...