Maximilian Roos

Discussed on the dev call — let's go for the second approach — "Require passing in the source into `WriteSource`"

Ah, I haven't been keeping this issue up-to-date, thanks for the ping @m-span . Relevant links: https://github.com/PRQL/prql/pull/4397#issuecomment-2187146337, https://github.com/PRQL/prql/pull/4639 Briefly: - The existing formatter uses PL. But PL doesn't have comments,...

Thanks for the issue — I think this is a dupe of the issue from https://github.com/PRQL/prql/pull/4037...

> As an aside, I noticed that even without the panic, the `sort` does not translate into an `ORDER BY` in the `from_b` CTE. Right, good spot, the result should...

Super, thanks for tracking that down

FYI this is no longer a panic, instead now points to #3870

Relies on https://github.com/rhysd/actionlint/issues/393, or we add a config file in the meantime

> It has been announced that macos-latest will switch from 12 to 14 in a few months, so it may be better to specify the version without using latest. Should...

I left the old mac-os ones there for the moment; we can remove when this becomes `latest`, or I'm fine with someone doing it sooner if they think that's better

@Seddryck this looks great! Thanks for making so much progress. If we can add a GHA, we can definitely merge...