prql icon indicating copy to clipboard operation
prql copied to clipboard

Published 20 hours ago • verified publisher icon PRQL

ci: Add macos-14 to CI

Open max-sixty opened this issue 1 year ago • 4 comments

max-sixty avatar Feb 02 '24 23:02 max-sixty

Relies on https://github.com/rhysd/actionlint/issues/393, or we add a config file in the meantime

max-sixty avatar Feb 03 '24 00:02 max-sixty

It has been announced that macos-latest will switch from 12 to 14 in a few months, so it may be better to specify the version without using latest.

eitsupi avatar Feb 03 '24 02:02 eitsupi

It has been announced that macos-latest will switch from 12 to 14 in a few months, so it may be better to specify the version without using latest.

Should we keep 12 after that change, though?

max-sixty avatar Feb 03 '24 03:02 max-sixty

Should we keep 12 after that change, though?

I suspect that even at this stage there is no need to keep 12, since macOS cross-compilation seems to work fine, wouldn't it be enough to just switch from latest to 14? Due to differences in machine performance, 14 tends to finish processing faster. The smaller size of the matrix will also ease CI congestion.

eitsupi avatar Feb 03 '24 09:02 eitsupi

I left the old mac-os ones there for the moment; we can remove when this becomes latest, or I'm fine with someone doing it sooner if they think that's better

max-sixty avatar Mar 18 '24 02:03 max-sixty