Maximilian Roos

Results 1204 comments of Maximilian Roos

Thanks for reviewing — I should probably either finish this or merge it, sorry for leaving it hanging for so long...

Note to future self (or if someone else finishes this) — we should add the ability to use `maturin develop`, since that installs the python package in a single step....

Most of this was added in a separate PR

Thanks — I think this sort of thing is good. Rather than interrupting the flow with a popup asking for a query name, how about a button for "Clear query"...

> What about saving the query before clearing the query and notifying the user before that? I think it's a better experience for the user I don't think we want...

> Is "Clear query" really useful? I think it's somewhat useful... :) Isn't "Clear query" + "Rename" the same as "New Query"? Minimum surprise is important — and the current...

Yes, tabs could be good! (It does seem like a much bigger project, though...)

> 1. https://stat.ethz.ch/pipermail/r-package-devel/2023q4/010147.html [↩](#user-content-fnref-1-f7c4a898b2b30b284bcd0ab176ce1622) That's unfortunate...

I was +1 on this — we could have other things such as dialect?