Maximilian Roos

(I edited this a few times, was working through it in my own mind...) I just added this to the description: > - Do we want to elide parentheses around...

> because it would move comments around, as AST would not capture where exactly the comment was (on the same line as code, in a new line, maybe indented?). This...

FYI I looked at adding comments to the lexer (not the parser), so we could use that to grab the comments. (#4094 was some of this) It's not difficult in...

I've done a few PRs to add important whitespace to the lexer — I think now complete. We still need to decide how we add that to the output (@aljazerzen...

Not a full reply, but: > remove `'` for quoting string (reason: unnecessary) I'm up for this iff we can find a way of representing inner `"` without escaping. Rust...

Tests are failing because of https://github.com/PRQL/prql/issues/2079, so I guess we need to solve that first

> I did not want throw an error here, because we don't have an easy escape path. (see the comment that was removed). There are two cases I can see:...

> When there is `take 1` it should yes, but `group x (take 2)` should not. Good point. Ideally we'd be able to handle those cases differently, I recognize that...

I agree we could elide the `ORDER BY` at the end. (i wouldn't prioritize it _that_ highly, but it is a good point) (Thanks for the excellent reply @snth!)

(for anyone comparing the queries — it's the final term that is incorrect — `id` vs `value` — agree this seems to be a bug)