Maximilian Roos
Maximilian Roos
Thanks @flying-sheep (responding quickly, will come back to this) — what's an example of when the proposed implementation will be better than the existing one?
Ok, yes, that makes sense. It's slightly over-specified IIUC — we only care about threadsafe — but nicely complete if someone wants to use it more broadly. Agree re API...
Would love to see this merged — particularly helpful for removing `bar()` in `foo.bar().baz()`...
This is indeed intentional — the role of coordinates is to have things which _aren't_ computed along. That's particularly the case when doing something like `.lag` — we don't want...
Yes, very reasonable @derhintze ! Good point around `coarsen`. I do think that's somewhat specific to `coarsen`, where it's applying a transformation to coords / labels. I agree it makes...
Closing as unlikely to inspire change, please reopen if anyone disagrees
Nice! Interesting re the git issue. I agree the commit doesn't seem to exist. But OTOH it does state here that that does seem to be the commit... https://github.com/PRQL/prql/actions/runs/9395042476/job/25873760775?pr=4546#step:2:56 I...
Yes seems like we need something like: https://github.com/actions/checkout/issues/217#issuecomment-900923602
No obligation to use vergen, but: - when I run this I don't get the version — is there a different check you're running? ``` cargo run -p prqlc --...
> I'm not sure how this works with downstream packages. What happens if I install from crates.io? It would need to fall back to just the version number