Maximilian Roos
Maximilian Roos
OK — sounds like the ports are working from within the container, and VS Code is attempting to forward the ports but somehow something is getting in the way. It...
Will close since it's not a PRQL issue but feel free to continue any discussions....
What's the advantage of running `rustfmt` over `cargo fmt`? I haven't seen projects do the former... Why would they give different outputs?
@m-span is there any chance you might have local configs which cause different outputs? If I pull this branch and then run `pre-commit run -a`, the rust code all resets...
> I ask because in order for other branches to 'pass', they have to cargo fmt files that weren't even affected? If this is a hard requirement, how did it...
Is there possibly a config file in one of these locations: > If none of these directories contain such a file, both your home directory and a directory called rustfmt...
(as an example of this — here's a `skip` comment: https://github.com/PRQL/prql/blob/76c4f767c4312976dba0fbadfa6c27b84e31faa9/prqlc/prqlc/tests/integration/queries/read_csv.prql#L2)
FWIW something that replaced the panic with an error of type [Bug](https://github.com/PRQL/prql/blob/10f98d723496f3bc69c3ee4a27651d991f266a49/prqlc/prqlc-ast/src/error.rs#L47) would be a welcome contribution!
FYI I merged main in, as merging the import sorting wasn't as trivial as I had hoped; and keen to not slow this down. Also added a reference to this...
Looks good! We can def merge pending tests + formatting...