Maximilian Roos

Results 1137 comments of Maximilian Roos
trafficstars

> > But, this gives new flake8 errors: > > > > I think CI runs `flake8 numba` so this wouldn't usually be an issue - all the errors are...

> As for the formatting, any PRs that auto-format are usually quite large and contain many false positives, so the usually just go through multiple rounds of reviews and eventually...

(I moved the dev tools discussions to other issues. This PR is ready for a second review — thanks!)

No urgency but it states still Waiting on Author — I think it's now ready for you to merge — lmk if that's not correct

This would be great to fix. It's probably not a trivial fix given the code grammar is in TextMate, but also not impossible — rust does manage:

Specifying each operator prefix in a regex — `&& !(vim.command =~ /^[dcygvz> ```json // This keybinding activates in Vim Normal mode, but only when vim.command // does not start with...

I'm not the expert, but this looks reasonable! Any other thoughts? Assuming no one thinks it's a bad idea, we would need tests.