Maximilian Roos

Results 1162 comments of Maximilian Roos
trafficstars

> IIUC, that feature has been removed. OK thanks, sounds like we did remove it. If this is important for quary, we could come up with something...

Would upgrading them and publishing an mdbook 0.5.0 make sense? We're currently locked on an older version of `pulldown-cmark` in PRQL since we're pinned to the mdbook version... Thank you!

FYI note this is only the case for dynamic gufuncs — with a signature no output is required: ```python @guvectorize([(numba.int64[:], numba.int64[:], numba.int64[:])],'(n),(n) -> (n)') def add(a, b, res): for i...

> From a quick skim it looks like the tests aren't platform-agnostic WRT the way paths are formed (the root, and separators) - I haven't looked deeper, but perhaps `pathlib.Path`...

> It doesn't use pytest because there's a lot of homegrown addons to `unittest` that have been added over the years, and porting them over to pytest wasn't trivial (there...

Hi team — the gentlest of pings here. I know things can get backlogged. I do think this is a fairly small unambiguous improvement, with some decent comments and a...

No prob re empty commit, push away. Docs error seems unrelated though? ``` numba/_helperlib.c:22:44: error: ‘I’ undeclared (first use in this function) 22 | #define _complex_float_ctor(r, i) (r + I...

Thanks a lot for the thorough review @guilhermeleobas. I've made those changes and it should be ready for merging / another review.

I fixed some flake8 issues. On the topic of dev friendliness: - `pre-commit` uses a different version of flake8 which doesn't work (at least on my system) - `flake8` generates...