Matt Nolting

Results 43 comments of Matt Nolting
trafficstars

~~Currently, the Insights team is working on a performant approach that leverages very lightweight JS and resize observer. This solution will be added to an updated proposal which will be...

> Why would you want to use some JavaScript for something that's provided natively by CSS and is in all browsers now (container queries)? Using JavaScript for something like this...

> @mattnolting worked on the masthead and toolbar - can you verify we're no longer using `isFullHeight` on the toolbar in the masthead? And do you know what we're doing...

> But, that issue has label "wontfix"... "wontfix" has been removed @thatblindgeye transferring this issue to pf react

@kmcfaul @ajaypratap003 From: https://www.patternfly.org/components/masthead/html-demos/horizontal-nav/ ![Screenshot 2024-05-08 at 12 44 27 PM](https://github.com/patternfly/patternfly-react/assets/5385435/6fc5b910-896a-4d69-82cf-1be4d3357443)

> > `nav` goes inside a `toolbar__item` with the class `pf-m-overflow-container` > > **Current** > > > > **update** > > nav is already inside toolbar_item. this is the latest...

Need to remove Banner - breadcrumb - codeblock - codeEditor These are all in Batch-3

> @mattnolting FYI it looks like the old files within `react-core/` weren't removed from this PR when they were moved up a directory @evwilkin Great catch, updated

https://github.com/patternfly/patternfly/pull/6167/files/88dd1182d2456ddc1750a186db004e40759ce642#r1468135792