Matt Nolting
Matt Nolting
@mcoker @mcarrano @mmenestr This is how the vertical tabs present currently in context:   I...
@mcarrano The only demos that showcase the expandable, vertical tabs are the new demos in this PR. They are present in examples only. - https://patternfly-pr-4850.surge.sh/components/tabs/html-demos/vertical-tabs/ - https://patternfly-pr-4850.surge.sh/components/tabs/html-demos/vertical-tabs-full-height/
@mcoker Thanks for the detail and screenshots > Maybe we should put this on hold until we can take a look in design? @mcarrano Yes, I agree. I think we...
> Should the vertical line be visible on https://patternfly-pr-4850.surge.sh/components/tabs/html-demos/vertical-tabs/ ? > > You can (not!) see it here: https://user-images.githubusercontent.com/19825616/189410702-840a68a5-af20-447a-8798-104167553282.mp4 @mcarrano wdyt?
> @mcarrano OpenShift is using vertical tabs here http://openshift.github.io/openshift-origin-design/designs/administrator/future-openshift/user-preferences/ and Satellite is using them here https://marvelapp.com/prototype/1121a8de/screen/72413287 @doruskova Thanks for the refs! Looks like OS does not have a vertical divider...
@mcoker @srambach I've updated the vertical, expandable tabs, box variant support. The extended borders are drawn by the sidebar component.
@mcarrano Since we're supporting dark theme universally now, we'll need a spec for dark/light mode as a button anywhere could serve as this drawer toggle, and any interaction states you...
@mcarrano The toolbar items are vertically aligned center by default. The fix for this is to align items baseline or top and add a modifier to align items center, to...
@jamestalton I agree, we plan to address in the upcoming breaking change release.