Matt Nolting

Results 43 comments of Matt Nolting
trafficstars

@mcarrano It's additional work. The core component is done, but the only react implementation is embedded in `pf-c-table`. https://www.patternfly.org/v4/documentation/react/components/table#editable-rows. I'd defer to React @tlabaj as to a standalone React implementation.

> This satisfies the immediate request, but I wonder if we could just open it up so that someone can put in whatever kind of layout they want (and let...

I love this, it's so slick! This would shrink the CSS by boatloads! I'm definitely in favor of your last example. ``` .pf-c-component { // Define everything in SCSS instead...

@mceledonia We included the disabled state in the initial nav updates, but made many assumptions in doing so. As a result, the disabled states didn't pass color contrast testing. ![image](https://user-images.githubusercontent.com/5385435/78902572-f763c900-7a47-11ea-8030-4e24179bb00b.png)

Remove as many `scss` variables as possible 👍

@rebeccaalpert Looks like the nested table is missing `table thead/tbody`. Can you update that and let us know if that fixes the issue. ![Screenshot 2024-02-28 at 10 14 30 AM](https://github.com/patternfly/patternfly/assets/5385435/1bfddb74-0c9e-4f28-a6a0-5d09cb5584da)

Related to [#5111](https://github.com/patternfly/patternfly/issues/5111). The best path forward lies within container queries and resize observer based selector/modifier changes, rather than relying on static breakpoints. That work is ongoing, we'll revisit this...

@mcoker I'm good w/closing this and later opening `margin-trim` issue

### TLDR; Using container queries and resize observer would replace our current approach to {breakpoint} suffixed layout modifiers, resulting in significantly reduced CSS filesize/s. Each instance of breakpoint based modifiers...