patternfly-react
patternfly-react copied to clipboard
Masthead: add demo that includes horizontal nav
What: Closes https://github.com/patternfly/patternfly-react/issues/6826 Masthead: add demo that includes horizontal nav
Additional issues:
Preview: https://patternfly-react-pr-10241.surge.sh
A11y report: https://patternfly-react-pr-10241-a11y.surge.sh
@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.
@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.
@tlabaj Can you please share the commit which is related to this PR
@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.
@tlabaj Can you please share the commit which is related to this PR
@ajaypratap003 Nevermind. I was mistaken. it was a Nav example that was added.
@tlabaj Can you please merge this PR if everything look good.
Nice work! Looks like you need to add
toolbarto.pf-v5-c-masthead__content.![]()
@mattnolting Sorry, I don't get this point. Can you please describe bit more
@kmcfaul @ajaypratap003 From: https://www.patternfly.org/components/masthead/html-demos/horizontal-nav/
navgoes inside atoolbar__itemwith the classpf-m-overflow-containerCurrent
**update**
![]()
nav is already inside toolbar_item. this is the latest commit https://github.com/patternfly/patternfly-react/pull/10241/commits/525f4a7b7b89695cc40fc1a4d7fac8d79aa6ce00
navgoes inside atoolbar__itemwith the classpf-m-overflow-containerCurrentupdate
nav is already inside toolbar_item. this is the latest commit 525f4a7
Still can't see these.
This private-user-images.githubusercontent.com page can’t be found
**update**