patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Masthead: add demo that includes horizontal nav

Open ajaypratap003 opened this issue 1 year ago • 9 comments
trafficstars

What: Closes https://github.com/patternfly/patternfly-react/issues/6826 Masthead: add demo that includes horizontal nav

Additional issues:

ajaypratap003 avatar Apr 03 '24 12:04 ajaypratap003

Preview: https://patternfly-react-pr-10241.surge.sh

A11y report: https://patternfly-react-pr-10241-a11y.surge.sh

patternfly-build avatar Apr 03 '24 12:04 patternfly-build

@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.

tlabaj avatar Apr 24 '24 20:04 tlabaj

@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.

@tlabaj Can you please share the commit which is related to this PR

ajaypratap003 avatar Apr 25 '24 11:04 ajaypratap003

@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.

@tlabaj Can you please share the commit which is related to this PR

@ajaypratap003 Nevermind. I was mistaken. it was a Nav example that was added.

tlabaj avatar Apr 25 '24 13:04 tlabaj

@tlabaj Can you please merge this PR if everything look good.

ajaypratap003 avatar Apr 26 '24 16:04 ajaypratap003

Nice work! Looks like you need to add toolbar to .pf-v5-c-masthead__content.

Screenshot 2024-04-30 at 1 32 47 PM

@mattnolting Sorry, I don't get this point. Can you please describe bit more

ajaypratap003 avatar May 07 '24 12:05 ajaypratap003

@kmcfaul @ajaypratap003 From: https://www.patternfly.org/components/masthead/html-demos/horizontal-nav/

Screenshot 2024-05-08 at 12 44 27 PM

mattnolting avatar May 08 '24 16:05 mattnolting

nav goes inside a toolbar__item with the class pf-m-overflow-container

Current

Screenshot 2024-05-08 at 2 20 31 PM **update** Screenshot 2024-05-08 at 2 20 19 PM

nav is already inside toolbar_item. this is the latest commit https://github.com/patternfly/patternfly-react/pull/10241/commits/525f4a7b7b89695cc40fc1a4d7fac8d79aa6ce00

ajaypratap003 avatar May 08 '24 18:05 ajaypratap003

nav goes inside a toolbar__item with the class pf-m-overflow-container Current Screenshot 2024-05-08 at 2 20 31 PM update Screenshot 2024-05-08 at 2 20 19 PM

nav is already inside toolbar_item. this is the latest commit 525f4a7

Still can't see these.

This private-user-images.githubusercontent.com page can’t be found

mattnolting avatar May 14 '24 13:05 mattnolting