patternfly-design
patternfly-design copied to clipboard
patternfly
Nav component doesn't have a disabled state for links
In the docs there is a .pf-m-disabled for .pf-c-nav__link but no styles for the state were written.
I think I'm going to remove this disabled modifier from the docs until we determine the need for the disabled styling/have designs for it. Does that sounds ok @mcarrano @kybaker
OK with me @christiemolloy @kybaker do you see any need for this? Did we ever design a disabled state for nav items?
I did some quick digging on this I see that Bootstrap, Material design, and Polaris all offer a disabled state for navigation items. This how Material explains it:
Display actions as disabled when they can only be used sometimes, under certain conditions. They should be displayed as disabled rather than removing them.
https://getbootstrap.com/docs/4.3/components/navs/#base-nav https://polaris.shopify.com/components/navigation/navigation
Worth considering @mcarrano @kybaker ?
We may need this for cloud.redhat.com - we have been exploring the option to show users sections that they are not yet entitled to use.
@mceledonia We included the disabled state in the initial nav updates, but made many assumptions in doing so. As a result, the disabled states didn't pass color contrast testing.
@mattnolting Disabled UI elements aren't required to meet contrast ratios, but I think we can still improve the visuals/contrast. I'll try something soon and get back to you on here.
CC @mcoker @mcarrano
This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.
I am going to move this to our design backlog but will not add to the roadmap until or unless we have a specific product use case for this.
Per discussion today with @mceledonia @lboehling @mmenestr we agreed this should be closed. If nav items are unavailable we should either hide or display and empty state.