Mark Mandel

Results 978 comments of Mark Mandel

🤔 I wonder if we don't catch the condition in a `Static` config. Can you try a dynamic port config?

This looks to be the magic line of concern: https://github.com/googleforgames/agones/blob/06ae7a834f5fb08ed8d4b7cc91cb88d8f21eff2c/pkg/gameservers/portallocator.go#L155-L157 Reference for GameServer - see `ports` section: https://agones.dev/site/docs/reference/gameserver/

On review with @SaitejaTamma , really we should move the custom logic from portallocator.go to https://github.com/googleforgames/agones/blob/9fa432c24d5aefbfcd6cf7eef61fcd4b35034663/pkg/apis/agones/v1/gameserver.go#L594-L599 Since `GameServer.Pod(...)` is the central place that handles the creation of a Pod's container...

Since multi-cluster work tends to be platform specific, you will need to implement this yourself for your specific platform. We do have https://agones.dev/site/docs/advanced/multi-cluster-allocation/, although that doesn't answer your specific question.

🤔 Do we know which library is bringing in that package? I assume it's gRPC? And if so, do we know which version that gRPC switched over to the newer...

Let us know how it goes. `make gen-sdk-grpc` is the target we use to generate grpc code for each SDK. https://github.com/googleforgames/agones/blob/main/build/README.md#make-gen-sdk-grpc

@robbieheywood if you can work out what this metric is for, we would love a pull request! 😃

Writing this down so I can find it again. https://sslip.io/ (or related, linked on page) would work very well for this. Either self hosted, or with a custom domain name...

Renaming the ticket, as a reference to write up a document on integration with websockets in https://agones.dev/site/docs/integration-patterns/

Updated C++ checklist, due to #948