Luke Dashjr

Results 690 comments of Luke Dashjr
trafficstars

Would prefer the refactoring split into a different commit

Propose these changes: https://github.com/john-moffett/bitcoin-gui/compare/2022_12_FixReceiveCoinsMultiselect...luke-jr:bitcoin-core-gui:qt_reqs_multiselect_pr684

> we are enforcing this rules within the descriptors parsing logic. That sounds dumb. Why are we?

I've implemented a new setting to turn off JIT, but my patch is against mainline Chromium and I don't really have the time to sort out whether they will apply...

Originally, Chromium had this option for JAVASCRIPT_JIT, but replaced it with JAVASCRIPT_OPTIMIZE when Webasm was released (details elided). When that happened, they cleared all the previous _JIT site overrides since...

Actually, since this is changing the setting default rather than assigning to it, it's entirely possible that I don't have it set still, and toggling it back would lose my...

`std::vector` is probably less likely to have bugs that `std::set`, so there's an improvement in that regard as well. I feel like we shouldn't need to fully sort, though. Perhaps...

>I'm open to adding an option to disable automatic updates per-app. However, I'd like to know what use cases you or other people have for this. It changes a "trust...

Perhaps even with automatic updates disabled, making it prominent that an update is available and needs manual interaction?

Assigned BIP number 352