Luke Dashjr

Results 690 comments of Luke Dashjr
trafficstars

@achow101 Are you sure you want to put this on a common domain with other things?

AFAIK there is software which reads these files intentionally. IMO they can be expected to adapt, but having the option to disable it seems like a good idea in case...

I guess we should save a "reindex needed" flag somewhere when LevelDB corruption causes the node to shutdown? > [I wish I could re-download only the blocks since then, not...

>This should really be looked into, seeing this a lot more with our hardware now that blocks are full If the chainstate is getting corrupt, that points to a hardware...

Concept NACK, consumers should just check if features are available

Consumers don't need the entire RPC surface, only specific parts. If a compatibility check is desired, that's indeed how it should be (and typically is) done - just like autotools/cmake...

Seems like an awful lot of refactoring and optimisations tied into what is in essence a bugfix. Maybe split them up?

Looks like this works around a regression introduced by #20640 Might be better to make `CreateTransaction` return a (non-optional) `CreatedTransactionResult` instead?

Concept NACK. This seems to encourage and promote spam. We should be doing the exact opposite. Curious why you say "creation was already standard" - I don't see why that...

>This proposal is merely a way of doing something that is already done - signed anchor outputs - in a more efficient way with less overall bytes consumed. And at...