Luke Dashjr
Luke Dashjr
>Since these are test-network-only changes, are we required to preserve current behavior? Whether you are required to or not, it is the correct thing to do. This option originated in...
This seems likely to have a high maintenance cost. What's the benefit?
>would this optimization be more welcome in https://github.com/bitcoin/libbase58 instead? The algorithm used in libbase58 is different, so not sure this even applies. Kinda doubt it would be worth the time...
Seems like this should freeze indexes, wallets, etc and hold a lock so nothing else happens during the process...?
This one-line change works without anything else: https://github.com/bitcoin-core/gui/pull/815#pullrequestreview-2072577992
Yes, I personally have used username-less (just a password) authenticated JSON-RPC.
This breaks connection reuse, and has a messy print() in it.
Hmm, this doesn't seem to actually _fix_ the issue, just avoids the infinite loop. In particular, by casting to a float you're not ensuring the Decimal value gets encoded correctly...
Uninstalling it still requires doing this first (since `apt-get remove` may fail due to a running unattended upgrade..)