Luke Dashjr

Results 690 comments of Luke Dashjr
trafficstars

Concept ~0. Doesn't seem worth it if we're moving to cmake soon.

Weak approach NACK. This is just limiting the max block weight, which is already a configurable parameter. Having two params for the same thing seems like a poor way to...

Not sure the asmap feature cares if your map is based on BGP or something else?

>Data publishing via unspendable UTXOs is undetectable. We can't block it without significant changes to the consensus protocol. This is false. It would require invasive changes to the address format...

I would do peer_id|peer_ids and accept both a single number (most common use) or an array (efficient).

Concept ACK But shouldn't the final confirmation dialog also have a "Go back" instead of "Cancel"? (Better yet, why don't we just show these warnings upfront in the password entry...

Can we make the exists/is_fifo/open atomic somehow? Seems liable to have a race here someday...

eg https://github.com/luke-jr/bitcoin/commit/56ee485533820d8c7f0e4e27acd712aa8b411286