Oleksandr Fediashov

Results 261 comments of Oleksandr Fediashov
trafficstars

@AkiraVoid the workaround is to disable Strict mode: ```js // next.config.js // https://nextjs.org/docs/api-reference/next.config.js/react-strict-mode module.exports = { reactStrictMode: false, } ``` ~~However it should be fixed in `@fluentui/[email protected]` by #24061. Can...

@AkiraVoid ^ check the recent edit 🐱 I just checked and indeed the only solution for now is to disable `StrictMode`.

> And, since v8, the numbers after class names seem to be a problem in SSR (also mentioned in this thread). Should I open another issue about this? Nope, we...

> @layershifter i tried the example on https://react.fluentui.dev/?path=/docs/concepts-developer-server-side-rendering--page for Nextjs + Typescript. I get an error in _app.tsx "Property renderer does not exist on type 'AppProps'". Do you have any...

`IIconProps` extends both `IBaseProps` and `React.HTMLAttributes`: https://github.com/microsoft/fluentui/blob/958f4e2469b779d6e394fd6885ebd2532c7c229e/packages/react/src/components/Icon/Icon.types.ts#L34-L37 So documentation in https://developer.microsoft.com/en-us/fluentui?fabricVer=8#/controls/web/icon is correct. This is true for both `@fluentui/react@v7` & `@fluentui/react@v8`. --- The problem is that `React.HTMLAttributes` is not visible...

- Add documentation to preview section - Explain how to compose components and override `state.components.X`

FYI: ``` ERR! Warning: You have changed the public API signature for this project. Please copy the file "temp/react-menu.api.md" to "etc/react-menu.api.md", or perform a local build (which does this automatically)....

If we want to affect all components in a tree we can go only with "New token" or "CSS selector". I also proposed "React Context" option to determine defaults. IMO...

The problem is present for both Fluent UI React v7 & v8, so it's not a regression: - v7 https://codesandbox.io/s/nostalgic-framework-femhl8 - v8 https://codesandbox.io/s/compassionate-ritchie-e7759d This behavior looks intentional as both `label`s...