fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Charting: CherryPick# 24319-Culture issue in Multi Stacked bar chart solve

Open AnnapareddyHarsha opened this issue 3 years ago • 3 comments
trafficstars

Cherry-pick of 24319

Current Behavior

Accessibility tool showing error for chart title "ARIA roles used must conform to valid values"

image

New Behavior

The role should not be culture, it should be text or nothing just like other charts.

image

AnnapareddyHarsha avatar Aug 10 '22 09:08 AnnapareddyHarsha

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 674546b6b90d358ed13fd12a36b4d688c87ed81d:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

codesandbox-ci[bot] avatar Aug 10 '22 09:08 codesandbox-ci[bot]

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 94cb7fbdc1b68428d8ea8d69a19a1bcf1f11484d (build)

size-auditor[bot] avatar Aug 10 '22 09:08 size-auditor[bot]

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 766 760 5000
Breadcrumb mount 36716 36196 5000
Checkbox mount 1322 1320 5000
CheckboxBase mount 1096 1080 5000
ChoiceGroup mount 4227 4253 5000
ComboBox mount 767 825 1000
CommandBar mount 6709 6741 1000
ContextualMenu mount 12187 12233 1000
DefaultButton mount 961 963 5000
DetailsRow mount 3215 3201 5000
DetailsRowFast mount 3241 3201 5000
DetailsRowNoStyles mount 3005 3022 5000
Dialog mount 1938 1919 1000
DocumentCardTitle mount 1569 1564 1000
Dropdown mount 2097 2146 5000
FocusTrapZone mount 1444 1489 5000
FocusZone mount 1532 1539 5000
IconButton mount 1457 1498 5000
Label mount 283 289 5000
Layer mount 1689 1659 5000
Link mount 377 377 5000
MenuButton mount 1235 1222 5000
MessageBar mount 1769 1762 5000
Nav mount 2785 2786 1000
OverflowSet mount 1176 1201 5000
Panel mount 1224 1244 1000
Persona mount 813 843 1000
Pivot mount 1231 1249 1000
PrimaryButton mount 1093 1092 5000
Rating mount 6636 6639 5000
SearchBox mount 1068 1071 5000
Shimmer mount 2204 2207 5000
Slider mount 1280 1283 5000
SpinButton mount 4296 4367 5000
Spinner mount 365 358 5000
SplitButton mount 2712 2682 5000
Stack mount 413 423 5000
StackWithIntrinsicChildren mount 1459 1456 5000
StackWithTextChildren mount 4048 4088 5000
SwatchColorPicker mount 9040 9116 5000
TagPicker mount 2434 2492 5000
TeachingBubble mount 43451 43669 5000
Text mount 362 368 5000
TextField mount 1191 1173 5000
Toggle mount 689 700 5000
button mount 95 96 5000

fabricteam avatar Aug 10 '22 09:08 fabricteam

/azp run

layershifter avatar Aug 16 '22 10:08 layershifter

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 16 '22 10:08 azure-pipelines[bot]