fluentui
fluentui copied to clipboard
chore: fix `no-context-default-value` lint violations for teams-prg
Addresses #21338
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 1d9e56b1c6ffb9aa67daaf5ed7c8038010ed80a2:
| Sandbox | Source |
|---|---|
| @fluentui/react 8 starter | Configuration |
| @fluentui/react-components 9 starter | Configuration |
📊 Bundle size report
| Package & Exports | Baseline (minified/GZIP) | PR | Change |
|---|---|---|---|
| react-accordion Accordion (including children components) |
79.485 kB24.082 kB |
79.529 kB24.099 kB |
44 B 17 B |
| react-alert Alert |
82.771 kB20.584 kB |
82.874 kB20.608 kB |
103 B 24 B |
| react-avatar Avatar |
48.18 kB13.616 kB |
48.283 kB13.644 kB |
103 B 28 B |
| react-avatar AvatarGroupItem |
68.333 kB19.018 kB |
68.436 kB19.044 kB |
103 B 26 B |
| react-button SplitButton |
46.506 kB11.827 kB |
46.544 kB11.84 kB |
38 B 13 B |
| react-card Card - All |
67.42 kB19.249 kB |
67.47 kB19.273 kB |
50 B 24 B |
| react-card Card |
63.102 kB18.167 kB |
63.152 kB18.185 kB |
50 B 18 B |
| react-combobox Combobox (including child components) |
71.331 kB23.323 kB |
71.457 kB23.361 kB |
126 B 38 B |
| react-combobox Dropdown (including child components) |
70.459 kB23.182 kB |
70.585 kB23.22 kB |
126 B 38 B |
| react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover |
188.673 kB51.804 kB |
188.925 kB51.884 kB |
252 B 80 B |
| react-components react-components: FluentProvider & webLightTheme |
32.786 kB10.759 kB |
32.876 kB10.773 kB |
90 B 14 B |
| react-dialog Dialog (including children components) |
85.064 kB25.293 kB |
85.19 kB25.322 kB |
126 B 29 B |
| react-divider Divider |
16.321 kB5.837 kB |
16.359 kB5.853 kB |
38 B 16 B |
| react-menu Menu (including children components) |
114.702 kB35.037 kB |
114.927 kB35.102 kB |
225 B 65 B |
| react-menu Menu (including selectable components) |
117.901 kB35.533 kB |
118.126 kB35.592 kB |
225 B 59 B |
| react-overflow hooks only |
10.839 kB4.146 kB |
10.898 kB4.174 kB |
59 B 28 B |
| react-popover Popover |
102.111 kB31.328 kB |
102.267 kB31.373 kB |
156 B 45 B |
| react-portal Portal |
10.49 kB3.845 kB |
10.576 kB3.875 kB |
86 B 30 B |
| react-positioning usePositioning |
19.656 kB7.388 kB |
19.7 kB7.404 kB |
44 B 16 B |
| react-provider FluentProvider |
15.565 kB5.818 kB |
15.655 kB5.835 kB |
90 B 17 B |
| react-radio Radio |
36.13 kB11.947 kB |
36.218 kB11.982 kB |
88 B 35 B |
| react-radio RadioGroup |
14.319 kB5.711 kB |
14.357 kB5.729 kB |
38 B 18 B |
| react-slider Slider |
31.988 kB10.019 kB |
32.07 kB10.033 kB |
82 B 14 B |
| react-spinner Spinner |
19.81 kB6.369 kB |
19.848 kB6.384 kB |
38 B 15 B |
| react-switch Switch |
32.465 kB10.22 kB |
32.562 kB10.253 kB |
97 B 33 B |
| react-tooltip Tooltip |
41.313 kB14.59 kB |
41.504 kB14.622 kB |
191 B 32 B |
| react-utilities SSRProvider |
189 B161 B |
180 B159 B |
-9 B -2 B |
Unchanged fixtures
| Package & Exports | Size (minified/GZIP) |
|---|---|
| global-context createContext |
533 B341 B |
| global-context createContextSelector |
554 B348 B |
| react-avatar AvatarGroup |
15.068 kB6.016 kB |
| react-badge Badge |
22.503 kB7.153 kB |
| react-badge CounterBadge |
23.406 kB7.449 kB |
| react-badge PresenceBadge |
23.947 kB7.022 kB |
| react-button Button |
36.396 kB9.575 kB |
| react-button CompoundButton |
43.469 kB10.812 kB |
| react-button MenuButton |
39.014 kB10.456 kB |
| react-button ToggleButton |
51.91 kB11.003 kB |
| react-card CardFooter |
8.461 kB3.555 kB |
| react-card CardHeader |
9.504 kB3.896 kB |
| react-card CardPreview |
8.562 kB3.61 kB |
| react-image Image |
10.68 kB4.215 kB |
| react-input Input |
23.554 kB7.644 kB |
| react-label Label |
9.238 kB3.815 kB |
| react-link Link |
12.197 kB4.912 kB |
| react-select Select |
20.746 kB7.299 kB |
| react-spinbutton SpinButton |
43.899 kB12.362 kB |
| react-text Text - Default |
11.572 kB4.537 kB |
| react-text Text - Wrappers |
14.882 kB4.977 kB |
| react-textarea Textarea |
23.674 kB7.83 kB |
Asset size changes
| Project | Bundle | Baseline Size | New Size | Difference |
|---|---|---|---|---|
| office-ui-fabric-react | fluentui-react-DetailsList | 219.351 kB | 219.414 kB | |
| office-ui-fabric-react | fluentui-react-SearchBox | 175.84 kB | 175.903 kB | |
| office-ui-fabric-react | fluentui-react-ContextualMenu | 144.429 kB | 144.492 kB | |
| office-ui-fabric-react | fluentui-react-DatePicker | 174.181 kB | 174.244 kB | |
| office-ui-fabric-react | fluentui-react-PositioningContainer | 67.614 kB | 67.677 kB | |
| office-ui-fabric-react | fluentui-react-Dialog | 197.479 kB | 197.542 kB | |
| office-ui-fabric-react | fluentui-react-Pivot | 177.165 kB | 177.228 kB | |
| office-ui-fabric-react | fluentui-react-Pickers | 275.134 kB | 275.197 kB | |
| office-ui-fabric-react | fluentui-react-PersonaCoin | 107.079 kB | 107.142 kB | |
| office-ui-fabric-react | fluentui-react-Persona | 107.079 kB | 107.142 kB | |
| office-ui-fabric-react | fluentui-react-Panel | 187.312 kB | 187.375 kB | |
| office-ui-fabric-react | fluentui-react-DocumentCard | 203.611 kB | 203.674 kB | |
| office-ui-fabric-react | fluentui-react-Nav | 176.335 kB | 176.398 kB | |
| office-ui-fabric-react | fluentui-react-Modal | 87.884 kB | 87.947 kB | |
| office-ui-fabric-react | fluentui-react-MessageBar | 176.882 kB | 176.945 kB | |
| office-ui-fabric-react | fluentui-react-Dropdown | 219.209 kB | 219.272 kB | |
| office-ui-fabric-react | fluentui-react-Layer | 44.044 kB | 44.107 kB | |
| office-ui-fabric-react | fluentui-react-Facepile | 198.309 kB | 198.372 kB | |
| office-ui-fabric-react | fluentui-react-Keytips | 98.667 kB | 98.73 kB | |
| office-ui-fabric-react | fluentui-react-KeytipLayer | 95.929 kB | 95.992 kB | |
| office-ui-fabric-react | fluentui-react-Keytip | 74.764 kB | 74.827 kB | |
| office-ui-fabric-react | fluentui-react-FloatingPicker | 228.555 kB | 228.618 kB | |
| office-ui-fabric-react | fluentui-react-HoverCard | 89.828 kB | 89.891 kB | |
| office-ui-fabric-react | fluentui-react-CommandBar | 189.331 kB | 189.394 kB | |
| office-ui-fabric-react | fluentui-react-Grid | 169.026 kB | 169.089 kB | |
| office-ui-fabric-react | fluentui-react-ComboBox | 235.525 kB | 235.588 kB | |
| office-ui-fabric-react | fluentui-react-SpinButton | 179.738 kB | 179.801 kB | |
| office-ui-fabric-react | fluentui-react-Breadcrumb | 188.345 kB | 188.408 kB | |
| office-ui-fabric-react | fluentui-react-Button | 183.087 kB | 183.15 kB | |
| office-ui-fabric-react | fluentui-react-Tooltip | 79.665 kB | 79.728 kB | |
| office-ui-fabric-react | fluentui-react-ButtonGrid | 169.026 kB | 169.089 kB | |
| office-ui-fabric-react | fluentui-react-TimePicker | 224.673 kB | 224.736 kB | |
| office-ui-fabric-react | fluentui-react-Callout | 77.232 kB | 77.295 kB | |
| office-ui-fabric-react | fluentui-react-TeachingBubble | 192.019 kB | 192.082 kB | |
| office-ui-fabric-react | fluentui-react-Coachmark | 85.844 kB | 85.907 kB | |
| office-ui-fabric-react | fluentui-react-SwatchColorPicker | 178.718 kB | 178.781 kB | |
| office-ui-fabric-react | fluentui-react-SelectedItemsList | 218.285 kB | 218.348 kB | |
| office-ui-fabric-react | fluentui-react-ShimmeredDetailsList | 229.839 kB | 229.902 kB | |
| office-ui-fabric-react | fluentui-react-ColorPicker | 123.102 kB | 123.165 kB | |
| office-ui-fabric-react | fluentui-react-northstar-SplitButton | 184.918 kB | 184.956 kB | |
| office-ui-fabric-react | fluentui-react-northstar-Chat | 158.008 kB | 158.046 kB | |
| office-ui-fabric-react | fluentui-react-northstar-Portal | 59.591 kB | 59.629 kB | |
| office-ui-fabric-react | fluentui-react-northstar-Dropdown | 204.929 kB | 204.967 kB | |
| office-ui-fabric-react | fluentui-react-northstar-Toolbar | 181.17 kB | 181.208 kB | |
| office-ui-fabric-react | fluentui-react-northstar-Tooltip | 112.32 kB | 112.358 kB | |
| office-ui-fabric-react | fluentui-react-northstar-Popup | 138.472 kB | 138.51 kB | |
| office-ui-fabric-react | fluentui-react-northstar-Dialog | 116.344 kB | 116.382 kB | |
| office-ui-fabric-react | fluentui-react-northstar-Datepicker | 193.67 kB | 193.708 kB | |
| office-ui-fabric-react | fluentui-react-northstar-MenuButton | 168.655 kB | 168.693 kB |
Over Tolerance (1024 B)
Over Baseline
Below Baseline
New
Removed 1 kB = 1000 B
Baseline commit: 84e2b1a8b1e8d2e9008297b6c35c76231ae3a31c (build)
Perf Analysis (@fluentui/react-components)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1481 | 1471 | 5000 | |
| Button | mount | 1126 | 1119 | 5000 | |
| FluentProvider | mount | 1800 | 1823 | 5000 | |
| FluentProviderWithTheme | mount | 738 | 733 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 681 | 694 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 728 | 735 | 10 | |
| MakeStyles | mount | 2314 | 2240 | 50000 | |
| SpinButton | mount | 3026 | 2956 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ProviderMergeThemesPerf.default | 3195 | 1052 | 3.04:1 |
| PopupMinimalPerf.default | 1404 | 516 | 2.72:1 |
| AnimationMinimalPerf.default | 433 | 386 | 1.12:1 |
| RefMinimalPerf.default | 193 | 177 | 1.09:1 |
| BoxMinimalPerf.default | 292 | 272 | 1.07:1 |
| ImageMinimalPerf.default | 315 | 294 | 1.07:1 |
| AttachmentMinimalPerf.default | 129 | 122 | 1.06:1 |
| ButtonMinimalPerf.default | 137 | 129 | 1.06:1 |
| AttachmentSlotsPerf.default | 930 | 882 | 1.05:1 |
| CardMinimalPerf.default | 462 | 438 | 1.05:1 |
| AvatarMinimalPerf.default | 161 | 155 | 1.04:1 |
| FlexMinimalPerf.default | 244 | 235 | 1.04:1 |
| GridMinimalPerf.default | 280 | 269 | 1.04:1 |
| ListMinimalPerf.default | 428 | 413 | 1.04:1 |
| TableMinimalPerf.default | 342 | 330 | 1.04:1 |
| ButtonSlotsPerf.default | 461 | 447 | 1.03:1 |
| InputMinimalPerf.default | 1104 | 1068 | 1.03:1 |
| ProviderMinimalPerf.default | 340 | 331 | 1.03:1 |
| ReactionMinimalPerf.default | 314 | 305 | 1.03:1 |
| IconMinimalPerf.default | 515 | 498 | 1.03:1 |
| VideoMinimalPerf.default | 541 | 526 | 1.03:1 |
| CarouselMinimalPerf.default | 390 | 384 | 1.02:1 |
| PortalMinimalPerf.default | 140 | 137 | 1.02:1 |
| TreeWith60ListItems.default | 133 | 131 | 1.02:1 |
| ChatWithPopoverPerf.default | 314 | 310 | 1.01:1 |
| DialogMinimalPerf.default | 645 | 639 | 1.01:1 |
| DropdownManyItemsPerf.default | 566 | 558 | 1.01:1 |
| HeaderSlotsPerf.default | 631 | 623 | 1.01:1 |
| LabelMinimalPerf.default | 313 | 309 | 1.01:1 |
| LayoutMinimalPerf.default | 301 | 298 | 1.01:1 |
| ListCommonPerf.default | 535 | 532 | 1.01:1 |
| MenuMinimalPerf.default | 718 | 709 | 1.01:1 |
| SegmentMinimalPerf.default | 286 | 283 | 1.01:1 |
| ToolbarMinimalPerf.default | 736 | 730 | 1.01:1 |
| TreeMinimalPerf.default | 686 | 679 | 1.01:1 |
| CheckboxMinimalPerf.default | 2254 | 2261 | 1:1 |
| DatepickerMinimalPerf.default | 4829 | 4824 | 1:1 |
| DividerMinimalPerf.default | 288 | 288 | 1:1 |
| EmbedMinimalPerf.default | 3476 | 3482 | 1:1 |
| ItemLayoutMinimalPerf.default | 999 | 1004 | 1:1 |
| ListWith60ListItems.default | 499 | 501 | 1:1 |
| LoaderMinimalPerf.default | 568 | 567 | 1:1 |
| MenuButtonMinimalPerf.default | 1401 | 1406 | 1:1 |
| RosterPerf.default | 939 | 942 | 1:1 |
| RadioGroupMinimalPerf.default | 374 | 373 | 1:1 |
| SliderMinimalPerf.default | 1409 | 1407 | 1:1 |
| SplitButtonMinimalPerf.default | 3616 | 3630 | 1:1 |
| AlertMinimalPerf.default | 219 | 222 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1255 | 1271 | 0.99:1 |
| ChatMinimalPerf.default | 612 | 619 | 0.99:1 |
| DropdownMinimalPerf.default | 2613 | 2652 | 0.99:1 |
| StatusMinimalPerf.default | 558 | 564 | 0.99:1 |
| TableManyItemsPerf.default | 1541 | 1549 | 0.99:1 |
| HeaderMinimalPerf.default | 286 | 292 | 0.98:1 |
| FormMinimalPerf.default | 325 | 334 | 0.97:1 |
| ListNestedPerf.default | 464 | 479 | 0.97:1 |
| SkeletonMinimalPerf.default | 277 | 285 | 0.97:1 |
| CustomToolbarPrototype.default | 2212 | 2288 | 0.97:1 |
| ChatDuplicateMessagesPerf.default | 229 | 239 | 0.96:1 |
| TextAreaMinimalPerf.default | 366 | 393 | 0.93:1 |
| TextMinimalPerf.default | 253 | 277 | 0.91:1 |
| TooltipMinimalPerf.default | 842 | 940 | 0.9:1 |
| AccordionMinimalPerf.default | 104 | 122 | 0.85:1 |
Perf Analysis (@fluentui/react)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 779 | 793 | 5000 | |
| Breadcrumb | mount | 2280 | 2308 | 1000 | |
| Checkbox | mount | 2240 | 2239 | 5000 | |
| CheckboxBase | mount | 1983 | 1976 | 5000 | |
| ChoiceGroup | mount | 3933 | 3926 | 5000 | |
| ComboBox | mount | 769 | 774 | 1000 | |
| CommandBar | mount | 8875 | 8851 | 1000 | |
| ContextualMenu | mount | 9590 | 9795 | 1000 | |
| DefaultButton | mount | 959 | 976 | 5000 | |
| DetailsRow | mount | 2981 | 3023 | 5000 | |
| DetailsRowFast | mount | 3059 | 2987 | 5000 | |
| DetailsRowNoStyles | mount | 2887 | 2865 | 5000 | |
| Dialog | mount | 2293 | 2305 | 1000 | |
| DocumentCardTitle | mount | 141 | 152 | 1000 | |
| Dropdown | mount | 2779 | 2756 | 5000 | |
| FocusTrapZone | mount | 1542 | 1579 | 5000 | |
| FocusZone | mount | 1526 | 1498 | 5000 | |
| IconButton | mount | 1395 | 1422 | 5000 | |
| Label | mount | 315 | 335 | 5000 | |
| Layer | mount | 2716 | 2696 | 5000 | |
| Link | mount | 446 | 432 | 5000 | |
| MenuButton | mount | 1222 | 1223 | 5000 | |
| MessageBar | mount | 1938 | 1836 | 5000 | |
| Nav | mount | 2630 | 2636 | 1000 | |
| OverflowSet | mount | 986 | 991 | 5000 | |
| Panel | mount | 1822 | 1819 | 1000 | |
| Persona | mount | 854 | 858 | 1000 | |
| Pivot | mount | 1131 | 1139 | 1000 | |
| PrimaryButton | mount | 1110 | 1105 | 5000 | |
| Rating | mount | 6619 | 6659 | 5000 | |
| SearchBox | mount | 1126 | 1128 | 5000 | |
| Shimmer | mount | 2162 | 2243 | 5000 | |
| Slider | mount | 1696 | 1668 | 5000 | |
| SpinButton | mount | 3971 | 3890 | 5000 | |
| Spinner | mount | 396 | 388 | 5000 | |
| SplitButton | mount | 2655 | 2476 | 5000 | |
| Stack | mount | 487 | 496 | 5000 | |
| StackWithIntrinsicChildren | mount | 1887 | 1869 | 5000 | |
| StackWithTextChildren | mount | 4632 | 4637 | 5000 | |
| SwatchColorPicker | mount | 9016 | 9721 | 5000 | |
| TagPicker | mount | 2052 | 2025 | 5000 | |
| TeachingBubble | mount | 74360 | 73580 | 5000 | |
| Text | mount | 413 | 386 | 5000 | |
| TextField | mount | 1131 | 1166 | 5000 | |
| ThemeProvider | mount | 971 | 965 | 5000 | |
| ThemeProvider | virtual-rerender | 629 | 643 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1398 | 1402 | 5000 | |
| Toggle | mount | 724 | 709 | 5000 | |
| buttonNative | mount | 108 | 104 | 5000 |
FYI:
ERR! Warning: You have changed the public API signature for this project. Please copy the file "temp/react-menu.api.md" to "etc/react-menu.api.md", or perform a local build (which does this automatically). See the Git repo documentation for more info.
ERR! [6:15:41 AM] x Error detected while running 'api-extractor:default'
ERR! [6:15:41 AM] x ------------------------------------
ERR! [6:15:41 AM] x Error: The public API file is out of date. Please run the API snapshot and commit the updated API file.
I would avoid updating any API files in this PR as much as possible as we don't expect changes in APIs.

