Oleksandr Fediashov
Oleksandr Fediashov
@radium-v FYI I moved `@floating/*` bump to a separate PR, also tests should be passing after `master` will be merged.
> Btw there is some behaviour change in the "Multiple Modals" example. > > Prod: when I click "Open first Modal", then "Proceed", then hit `Escape` both modals close. When...
> Make all the M365 products logos available in the fluent icons (we use them all the time for documentation). Right now, here are the missing icons: These icons are...
That indeed a bug, can be reproed in [our sandbox](https://griffel.js.org/try-it-out/?code=JYWwDg9gTgLgBAbziAhgawKYGUYE8A2GAzgDRxEAW0MFKAdgCZFwC%2BcAZlBCHAOQACAcyjB27DPgD0AY2gZeAbgBQSjAA9IsOAwzsUAV3zxUmHAWIAKBErhwuEGAC5EN23wBkcANpE8hAFQAvABEsvjQzlCCAEYWAEwALACsZIkADKkJAIwAlArBALq8ztZubmERfNH4KNJocACEoJow9DC8rrYsJK7dSix5SkA), too. https://github.com/microsoft/griffel/blob/31bb2215926d5224ed2bd50fe9a61677a756a02f/packages/core/src/runtime/compileCSS.ts#L35-L44 The function above is probably the source of the problem. (I hope that such CSS rules are not...
> BTW, can you elaborate about the performance issues? I understand that this selector is less performant than selecting by class, but do you think the performance hit will be...
@zoontek TBH I haven't investigated it yet, so I can share only generic steps... - Add support for emitting `__css()` as an option to `@griffel/tag-processor` (the same as does `@griffel/webpack-extraction-plugin`)...
Agree, however [`content](https://developer.mozilla.org/en-US/docs/Web/CSS/content)` should have a special handling in errors: ```ts makeStyles({ // ❌ should throw and recommend to do `content: '""'` root: { ":before" { content: '' } },...
FYI there might a problem on a consumer side with that change, as currently there is workaround to disable animations (they change `opacity`):  Whatever is done, we need to...
Indeed, good catch 👍 Would be nice to support it.