Lalit Kumar Bhasin

Results 452 comments of Lalit Kumar Bhasin

@alanwest I don't see any TLS config setting in the code above - are you setting any CA certificate(chain) in your example? Otherwise, the code is pretty similar to the...

@alanwest From OpenTelemetry perspective, there is no change in how TLS config is handled. The only relevant change done in OpenTelemetry v0.24 is an upgrade to Tonic v0.12.0. There are...

Thank you, @demurgos. This is quite thorough, and it's great to see that the validation for examples from otel-proto covering all three signals. Everything looks good overall, except for the...

> The remaining error are spurious diffs in the generated protobuf code. I'm not sure if it's just a bit flaky or related to my changes. This is fixed in...

@brucedlg you are correct. On the destruction of `scope` object, the currently active span is removed from the active context, so it is no longer active. The span only ends...

@psandana - Agree with the change. Moving directly to `proto/` dir, or else to `src/generated` dir ( so `src` contains `proto`, `generated` and `transform` dirs). And I think it would...

> Why is the reason to keep it as is? If you still plan to remove, just not now, I would suggest adding a deprecation notice. Yes, want to deprecate...

@psandana Sorry for late reply. > FYI, there is a feature gen-tonic-messages. Shall this be renamed also? Yes, that can be renamed. However, the gRPC code for services within `tonic`...

Also, to add the historical reason behind the existence of `tonic` directory - earlier both `tonic + prost` and `grpcio + protobuf` were supported for generating code, and so there...