Lalit Kumar Bhasin

Results 443 comments of Lalit Kumar Bhasin

@perhapsmaple Thanks for volunteering for this. Although the check should be done once during startup, I feel we can ignore this step for now. It should be safe to assume...

> Thanks for taking on the implementation for Gauge. > > A few early comments. Thanks for the comments. Need to add unit-tests before making it ready now.

closing as there needs a design change. Will raise a new PR.

Can't you set the key-value using attributes argument below: ``` void AddEvent(nostd::string_view name, opentelemetry::common::SystemTimestamp timestamp, const opentelemetry::common::KeyValueIterable &attributes) noexcept override; ``` Probably I didn't understand your question, if you can...

@VivekSubr It would be mapped as mentioned here - https://github.com/open-telemetry/opentelemetry-specification/blob/v1.26.0/specification/trace/sdk_exporters/jaeger.md#events But Jaeger exporter has been removed and you should be using OTLP exporter for this. Let us know if you...

Thanks for creating the issue. Adding for reference the relevant Specs PR - https://github.com/open-telemetry/opentelemetry-specification/pull/3540

Valid concern. The `SamplingResult::attributes` needs to stay valid for the duration of the `Tracer::StartSpan()` method's execution (not till the span's end). And it is difficult for Sampler implementation to guarantee...

> the solution is simple. > let ShouldSample can call SetAttribute . Well not that easy :) The Span doesn't exist when ShouldSample is called. As Span is created based...

Duplicate to #2184. I am working on the fix, tentatively planned to be resolved during this week.

@zhchai ~~I see that you are using default temporality for OTLP exporter, which is [Cumulative](https://github.com/open-telemetry/opentelemetry-cpp/blob/4cae6aae8ccbbb9e4e25345e642ec982eec663c7/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_options.h#L24). With this temporality, even when there is no new measurement for a given instrument within...