Lalit Kumar Bhasin
Lalit Kumar Bhasin
Got it, thanks. makes sense to have a separate repo that publishes a docker image of this tooling.
> The NoopLogger is supposed to return usable objects, not a nullptr. Good point. It should indeed return `NoopLogRecord`.
Good catch :)
> This looks like a lifetime issue with regarding common::AttributeValue. You are correct. The ostream-exporter uses [ReadWriteLogRecord](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/sdk/include/opentelemetry/sdk/logs/read_write_log_record.h) as recordable implementation, and the attributes are [stored as:](https://github.com/open-telemetry/opentelemetry-cpp/blob/054b0dc207c1f58e290d78cdaac5f314bc328b31/sdk/include/opentelemetry/sdk/logs/read_write_log_record.h#L190) ```cpp std::unordered_map attributes_map_; ```...
Agree, the fix should be straighforward to avoid the crash by using the owning types for attributes ( as done within [span-data](https://github.com/open-telemetry/opentelemetry-cpp/blob/0ca7d707a505ca482b07e1ede1b19c25e198380d/sdk/include/opentelemetry/sdk/trace/span_data.h#L314)) https://github.com/open-telemetry/opentelemetry-cpp/blob/0ca7d707a505ca482b07e1ede1b19c25e198380d/sdk/include/opentelemetry/sdk/trace/span_data.h#L314 I will pick up the issue after...
@t-b Also, apart from current issue I described, if your code has something like: ```cpp auto attributes = opentelemetry::common::MakeAttributes( {{ "key1" , some_value_1}, { "key2", some_value_2}}; logger->Debug("Logging attributes", attributes); ```...
Perhaps this needs to be documented better. The formatting of the message is not done by OpenTelemetry SDK, but the onus is on upstream agents or exporters who want the...
One option could be for otel SDK to provide an abstract interface for JSON serialization, with default implementation for nlohmann-json. And let user bring their custom implementation which could internally...
Nice work. Can we document this exporter as an section in [README.md](https://github.com/open-telemetry/opentelemetry-cpp/tree/main/exporters/otlp) ?
And @pyohannes can self-assign this one, he still knows the otel-cpp code better. jk :)