Kumar McMillan

Results 169 comments of Kumar McMillan
trafficstars

A reviewer might, for example, leave a comment like "when building the original source code given your instructions, I could not reproduce the same add-on source"

We do have an API to list comments but I think it needs some tweaks to support this issue. See https://github.com/mozilla/addons/issues/7118

@ioanarusiczki ah, I also noticed that the API could be faster here. I filed https://github.com/mozilla/addons/issues/7100 Here are some thoughts on the loading indicator - It's currently impossible to know if...

Yep, syntax highlighting was going to be my guess. It wasn't obvious to me from looking at the perf profile. Hmm. I need to learn how to analyze those better.

The quickest fix here is probably to disable syntax highlighting when we detect minification (long lines or something) then offer a button to put highlighting back, maybe.

Yes, maybe. There are a couple others that may be dupes but I was planning to check the STR and URLs for each to make sure we cover all cases.

We have a workaround in https://github.com/mozilla/addons-code-manager/issues/942 which should speed this up but, really, we can do syntax highlighting faster once https://github.com/mozilla/addons-code-manager/issues/928 lands so I'm going to keep this open as...

I advise to just keep an eye on facebook/create-react-app#7006 (the request for this feature in CRA) and possibly spend time on a patch for it, although let's prioritize that work...

Skipping linter messages could be a security risk so we should fix this.

If we only want `useEffect`, we might only need to wait on https://github.com/facebook/react/issues/15275