Kumar McMillan

Results 169 comments of Kumar McMillan
trafficstars

Oh, whoops! That definitely looks like a bug in mohawk. Thanks for all the detailed info.

whoops, I missed this. You should be able to assign me PRs that need review now. I'll assign myself.

Hah, github fail. I thought it was a PR, nevermind.

I think `require_content_hash=True` makes the most sense in the context of a receiver, let's go with that.

Hmm, I forget how to do this. `log.warning` is probably fine. It should have test coverage to make sure that the warning gets logged. I seem to recall there is...

FYI, NTP has a lot of security holes: https://blog.hboeck.de/archives/863-Dont-update-NTP-stop-using-it.html

requirements.txt needs `GitPython==0.1.7` for a quick fix!

@bobsilverberg hmm, I'm not sure what we should do here since it's a binary file, for which we don't display content

I noticed two issues while looking at this but I'm not sure if fixing them would have a big impact or not. * https://github.com/mozilla/addons/issues/1816 (browse API should be faster when...

Thanks, these examples will be really helpful in making improvements. > https://code.addons.mozilla.org/en-US/browse/2613096/versions/4918511/?allowSlowPages=false&path=js%2Fjquery-3.3.1.js takes about 10 seconds for the shortened file. The code for this file displays in about 3 seconds...