Kumar McMillan

Results 169 comments of Kumar McMillan
trafficstars

> However, if you yourself had added local commits to the branch and then checked out Janice's work, your local commits would be "lost". Could this be a potential issue?...

I've been using `hub pr checkout...` for my own branches a lot lately. It's easier than typing the branch name 😄 Because of this, I think it would be better...

I'm trying to implement the exact same thing as described by @gl0gl0 ^

Note that this would easily lead to `--jstests-url-file=test-suite-urls.txt` where a large number of URLs could be specified, one on each line

From chatting about this on IRC it sounded like the equal sign was causing errors in [node hawk](https://github.com/hueniverse/hawk) so we should definitely strip it in mohawk. Thanks.

whoops, that's for an experimental branch. Where did you see a traceback? Those shouldn't be imported but they might have snuck in while I was testing something.

Hi. Thanks for the bug report. What is the exact traceback you get? Is `response['Content-Type']` an empty string? If it is, I think it should work as expected (but maybe...

Here? https://github.com/kumar303/hawkrest/blob/dce22be5a0ebbbf61e4496f38fc13478220a66b9/hawkrest/middleware.py#L33 Hmm, yeah, I guess `response.get('Content-Type', None)` is the safest but we'd have to see if that solves it. It might need to be an empty string. If you...

No worries, I appreciate you taking the time to submit a bug report. I don't really use hawkrest or mohawk for anything in production which is why I suggested submitting...

Hi, thanks for the follow up. > But what if we just start with `response.get('Content-Type', None)` as that is working (for me). If more people start complaining about this, we...