addons-code-manager icon indicating copy to clipboard operation
addons-code-manager copied to clipboard

Port Compare page to the useEffect hook

Open kumar303 opened this issue 6 years ago • 3 comments
trafficstars

The Compare page grew some gnarly load/update logic in https://github.com/mozilla/addons-code-manager/pull/342

This component can be ported to useEffect which will simplify the loading logic and let us delete a bunch of the tests.

┆Issue is synchronized with this Jira Task

kumar303 avatar Mar 08 '19 17:03 kumar303

This could be done together with #111.

willdurand avatar Mar 08 '19 18:03 willdurand

I guess this is blocked by upstream for now because Enzyme (shallow) does not support Hooks: https://github.com/airbnb/enzyme/issues/2011.

willdurand avatar Apr 10 '19 14:04 willdurand

If we only want useEffect, we might only need to wait on https://github.com/facebook/react/issues/15275

kumar303 avatar May 29 '19 15:05 kumar303