Kevin Rushforth

Results 520 comments of Kevin Rushforth

Since this enhancement represents a behavioral change, and adds new API, it will need to be discussed on the [openjfx-dev](https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev) mailing list prior to review. A Draft PR can be...

As discussed in the bug report, it isn't at all clear that we should do this. @johanvos can make the call on this. /reviewers 2

I'll look at this in more detail later. You will likely need some error checking when calling the JNI methods (even though they should not ever return an error), and...

@gargoyle To clarify my inline comments, the minimal change you need to make is: 1. Change the tests of the four `jField` variables to remove the `> 0` (so it...

> Thinking about it, is there merit in changing the scalex and scaley checks to be != 0, as The main reason for checking at all is to prevent a...

@gargoyle have you decided whether to change the scale tests to be `> 0`? Other than that pending question, the only required changes are the two I listed above.

@jperedadnr can you re-review (only minor change since you last approved it)?