Kevin Rushforth

Results 491 comments of Kevin Rushforth
trafficstars

The fix seems fine to me. I recommend also adding a test for a vertical axis.

@JonathanVusich will you be able to update the test to add adding a test for a vertical axis? That's the only outstanding change at this point.

@JonathanVusich Once a review is in progress, please don't force-push your branch without a compelling reason, since that makes it harder to do incremental reviews. In the future, we recommend...

I do see that there are no changes from last time, which is good, so it will be fine for this time. When ready, you can add the new test...

We generally prefer unit tests where feasible, but in this case, I think the system tests are fine. I'll review this soon (I had missed your earlier update and then...

Would a targeted test for the failing case from the bug report make sense?

I did an initial build / test (on macOS) along with a quick look at the changes. This will take a bit more time to complete. As a P3 regression,...

Here are my general review comments. The new version of Marlin fixes the specific problem identified in [JDK-8274066](https://bugs.openjdk.java.net/browse/JDK-8274066). It also seems inherently more robust for large coordinates, which is a...

Thank you for confirming.