Kevin Rushforth

Results 520 comments of Kevin Rushforth

> I had a single method before that accepted `(String style, String ... names)`. Turns out it was a trap: it's easy to forget about it and simply supply a...

The following directories should be refactored / renamed from `rich` to `richtext` (the one in `doc-files` is causing the images to not show up in the generated docs) ``` modules/jfx.incubator.richtext/...

> You will need a CSR, because you propose to make the public `consumed` field private (and change its type). Thanks for pointing this out. I haven't had time to...

My thought on this bug was to fix it in the scenegraph, rather than forcing a complete repaint in the toolkit. The scenegraph tracks the state of what is dirty...

Yeah, your solution might be fine. I just wanted to take a look at an alternative (or rather ask Ambarish to).

Reviewers: @arapte @lukostyra

In reading through all of the comments again, I think that the proposed solution, with the addition of `entireSceneNeedsRepaint`, is a reasonable one. The only other question I have is:...

This seems like a reasonable enhancement. I'll review it (not immediately, though). @nlisker would you be willing to be the second reviewer? A couple general comments: 1. Since you propose...