Kevin Rushforth
Kevin Rushforth
@prrace Can you take a look at this?
I note that PR #1471 was originally proposed to address this. Can you highlight the differences? Are any of the comments added to that PR still relevant? I also note...
> > Maybe we should do that as a separate ticket. Changing the documentation of properties that have nothing to do with backgrounds and borders is probably a bit out...
> how do I set 3 reviewers and at least 2 "R"eviewers? You can't. You can set it to `/reviewers 2 reviewers` and ask others to also review.
I started writing up some notes for myself, but then thought it might be worth sharing. Here are my meta- suggestions/ reminders for those who want to review this PR....
I'm going to be reviewing this in spurts over the next couple of weeks or so. My initial comments will be focused on the `jfx.incubator.richtext` module, specifically the `RichTextArea` control,...
I was looking into what "editable" does in `RichTextArea`, and I think we need a new name for one of the methods and might also need a second convenience method....
I wrote a very simple test, something you might see in a "HelloRichTextArea", and it seems quite easy to get started. It did prompt a couple quick suggestions: `RichTextArea`: *...
It looks like you copied, rather than moved, `RichTextAreaDemo` from `tests/manual` to `apps/samples`. The former should be deleted.
> > This method seems redundant: `fromInlineStyle(style)` and `fromStyles(style)` are equivalent. Do we need both? > > These are not the same. > > `fromInlineStyle(String)` accepts as single string containing...