Kevin Boos

Closing per my above comment. Feel free to re-open later, but also note that I am restructuring how rooms are stored in the list of all rooms as per #185

See my latest PR #224 for more info on how I intended this design to work, which includes precise examples of the "storage vs. presentation" argument I made above.

Hi @WaterWhisperer, thanks for the comment/question, and welcome! Apologies for the delay in my response, I'm traveling this week (attending the Matrix conference, coincidentally). > This is a bit confusing,...

Oh, and I forgot about the main thing we also want to do on certain lifecycle events: stop and start the sync service.

Thanks Alvin. I'm a bit confused -- is this a replacement for #293, or something that should be merged in after #293 as an addition to it? Also, is it...

I noticed that my review has been requested here and that this has been marked as `waiting-on-review`. However, there's also another PR #494 that seems to supersede this. Can you...

Ok, that adds a bit of detail, but doesn't fully answer my question. Is #494 being closed? Is this being merged in and then #494 afterwards? @alanpoon's previous comments seem...

@ZhangHanDong can you please review this PR and the changes related to the room subscription stuff? there are a few modifications to files that you own.

> https://github.com/project-robius/robrix/blob/e888e99fa0a4b965a2228b58c56831ad2eea8838/src/sliding_sync.rs#L1187 > > shall we add a break in the loop when it returns error, rather than error popup? i don't think it matters much. We could break out...

> Relogin does not restore the dock state, Do you want to fix it in this PR or in another PR? As I said on the Robrix matrix channel, I...