Kevin Boos comments

Results 327 comments of


                                            Kevin Boos

Fix cargo clippy warnings

Thanks @dcampbell24! Does this include all of the crates, even optional ones? (specified using `make full` or by passing `--all-features` to cargo)? I'm traveling at the moment and can't check...

Fix cargo clippy warnings

I see. Yes, make commands don't run any clippy lints, that's only done via CI at the moment. Sorry to confuse you with that unrelated info. For this you'll just...

Implement `raw_mutex` and `mutex`

Thanks for the PR, and sorry it took me so long to review it. I've got a couple thoughts/questions first; we can also discuss this on Discord. To clarify, this...

Patch `owning_ref` to avoid (unused) unsoundness

Could also consider replacing `owning_ref` with https://crates.io/crates/reffers

Patch `owning_ref` to avoid (unused) unsoundness

I think we'll need to replace `owning_ref` entirely. Good candidates are: * `self_cell`: good but a bit limited * `ouroboros`: huge and perhaps too much build-time overhead * `reffers`: not...

Patch `owning_ref` to avoid (unused) unsoundness

Note that all other RustSec advisory database warnings have been addressed. `owning_ref` is all that remains

Patch `owning_ref` to avoid (unused) unsoundness

As an alternative and better solution, we no longer support using `owning_ref` anywhere in Theseus. All of the crates that use it have now been removed; all that's left is...

Use `unwrap_or_else` instead of `unwrap_or`, and `ok_or_else` instead of `ok_or`

We should also enable the clippy lint option that checks for `unwrap_or` and `ok_or`, and recommends using the `_else` versions instead!

Use `unwrap_or_else` instead of `unwrap_or`, and `ok_or_else` instead of `ok_or`

Closed by #641

Use the `mold` linker instead of `ld` or `lld`

Hmm I see. I haven't toyed with using `mold` yet but once I get around to it I will comment back here with our options for supporting it. If we...